Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update power-port/power-ports check #1

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Update power-port/power-ports check #1

merged 2 commits into from
Oct 9, 2020

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jul 28, 2020

Split the check for

if "power-ports" in deviceType or "power-port" in deviceType:
createPowerPorts(deviceType["power-ports"], dtSuccess.id, nb)

Into

if "power-ports" in deviceType:
createPowerPorts(deviceType["power-ports"], dtSuccess.id, nb)
if "power-port" in deviceType:
createPowerPorts(deviceType["power-port"], dtSuccess.id, nb)

Because it was causing issues

Otherwise this also worked without issue on v2.8.8!

Thanks for your work, this is the best importer I've found yet! Handles existing manufacturers / device types / ports flawlessly!

Copy link
Collaborator

@minitriga minitriga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@minitriga minitriga merged commit ee033cc into netbox-community:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants