Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inventory item component #1078

Merged
merged 10 commits into from
Oct 7, 2023

Conversation

ahlee1
Copy link
Contributor

@ahlee1 ahlee1 commented Oct 1, 2023

Related Issue

Lots of thanks to @btriller for the majority of the work on this PR
Previous PR for this: #1020

New Behavior

Allows assigning a component to an inventory item

Contrast to Current Behavior

We cannot assign a component to an inventory item

Discussion: Benefits and Drawbacks

Benefit: Users can optionally assign the component to an inventory_item.
Drawbacks:

  • It is not possible to update a created item with a component as we use components in the ALLOWED_QUERY_PARAMS
    ex: If you create item1 with no components and try again with components it will create a new inventory item.

Proposed Release Note Entry

Allow the assignment of components to inventory items

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

sc68cal
sc68cal previously approved these changes Oct 2, 2023
Copy link
Contributor

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, re-running the failing job, it looked transient

@ahlee1
Copy link
Contributor Author

ahlee1 commented Oct 2, 2023

Code looks good, re-running the failing job, it looked transient

I believe this carries over from this PR #1066 (comment)

@ahlee1 ahlee1 requested a review from sc68cal October 2, 2023 01:30
@ahlee1
Copy link
Contributor Author

ahlee1 commented Oct 2, 2023

Sorry for the last minute pushes, noticed the name weren't right for the tests.

@sc68cal
Copy link
Contributor

sc68cal commented Oct 3, 2023

The CI failure appears to be unrelated to your change. It appears something got merged that broke the tests. Investigating.....

@ahlee1
Copy link
Contributor Author

ahlee1 commented Oct 3, 2023

@sc68cal When I looked into it, the issue seems to be from netbox itself when they changed the way available ips are structured. netbox-community/netbox#13746

@rodvand rodvand merged commit 5f26b63 into netbox-community:devel Oct 7, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants