-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inventory item component #1078
feat: inventory item component #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, re-running the failing job, it looked transient
I believe this carries over from this PR #1066 (comment) |
Sorry for the last minute pushes, noticed the name weren't right for the tests. |
The CI failure appears to be unrelated to your change. It appears something got merged that broke the tests. Investigating..... |
@sc68cal When I looked into it, the issue seems to be from netbox itself when they changed the way available ips are structured. netbox-community/netbox#13746 |
Related Issue
Lots of thanks to @btriller for the majority of the work on this PR
Previous PR for this: #1020
New Behavior
Allows assigning a component to an inventory item
Contrast to Current Behavior
We cannot assign a component to an inventory item
Discussion: Benefits and Drawbacks
Benefit: Users can optionally assign the component to an inventory_item.
Drawbacks:
ex: If you create item1 with no components and try again with components it will create a new inventory item.
Proposed Release Note Entry
Allow the assignment of components to inventory items
Double Check
devel
branch.