feat: Add config-template support #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinDBreaK
force-pushed
the
add-config-template
branch
from
6e1939f
to
bdc34b3
Compare
rodvand
reviewed
Oct 18, 2023
rodvand
reviewed
Oct 18, 2023
|
@MinDBreaK This looks great - if you can just add a test or two it should be fine to merge. |
MinDBreaK
force-pushed
the
add-config-template
branch
2 times, most recently
from
409f838
to
120a87c
Compare
MinDBreaK
force-pushed
the
add-config-template
branch
from
120a87c
to
ac1b847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
The config_templates are supported
Proposed Release Note Entry
Add support for the config_templates
Double Check
develbranch.Notes : I have not yet added tests, I would like to be reviewed before changing anything, and made sure that it would be accepted.