Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmask "packaging module missing" error #1126

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

rostskadat
Copy link
Contributor

When the packaging module is missing the error will be masked because we try to use self.module before it has been initialized

Related Issue

NA -

New Behavior

This change make sure that the real error (missing packaging module) is not masked by an error arising from the use-before-initialization of the self.module attribute

Contrast to Current Behavior

The old behavior masked the error and made troubleshooting harder

Discussion: Benefits and Drawbacks

NA

Changes to the Documentation

NA

Proposed Release Note Entry

Fixed use-before-initialization for self.module

Double Check

  • [X ] I have read the comments and followed the CONTRIBUTING.md.
  • [ X] I have explained my PR according to the information in the comments or in a linked issue.
  • [ X] My PR targets the devel branch.

When the packaging module is missing the error will be masked because we try to use self.module before it has been initialized
@sc68cal
Copy link
Contributor

sc68cal commented Dec 6, 2023

Great catch thank you

@rodvand rodvand merged commit 3455821 into netbox-community:devel Dec 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants