Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1268 #1269

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Fix issue 1268 #1269

merged 4 commits into from
Jun 24, 2024

Conversation

aopdal
Copy link
Contributor

@aopdal aopdal commented Jun 17, 2024

Related Issue

#1268

New Behavior

Add related_object_type to custom field.

...

Contrast to Current Behavior

This allows for making changes to custom fields of type object and point to correct related object type in NetBox >= 4.0

...

Discussion: Benefits and Drawbacks

It's good to be able to configure custom fields of type object using Ansible also when running NetBox 4.0+

...

Changes to the Documentation

The new option is added in the documentation part of the file.

...

Proposed Release Note Entry

Add support for custom field type object in NetBox 4.0+

...

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@rodvand
Copy link
Contributor

rodvand commented Jun 21, 2024

Thank you for your contribution. We recently adjusted the CI workflow to match with Red Hat's certification process and therefore require a changelog fragment for each PR.

If you can just add one to the PR I will merge it right away :) (We will add it to the PR template).

@aopdal
Copy link
Contributor Author

aopdal commented Jun 21, 2024

I have done it and now its green, but if it's good is another question ;-)

@rodvand rodvand merged commit a157002 into netbox-community:devel Jun 24, 2024
50 checks passed
@aopdal aopdal deleted the issue_1268 branch June 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants