fixing bug #975 #1323
Draft
fixing bug #975 #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
The issue this PR is trying to fix is #975
New Behavior
this pull request changes the data object that will ultimately be sent to Netbox to include the assigned_object_id and assigned_object_type items.
it takes the interface_id that exists in interface and add an assigned_object_id that is equal to the interface_id and add an assigned_object_type item.
Contrast to Current Behavior
the current behavior will not assign an IP to an interface.
Discussion: Benefits and Drawbacks
the bug of not being able to assign an ip to an interface is apposing the vary idea of the module and should be a core part of it.
i merely act on this requirement.
Changes to the Documentation
the documentation already states this functionality, it was not implemented but it should have.
Proposed Release Note Entry
...
Double Check
develbranch.