nb_lookup.py: Add example for lookup with variable #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc68cal
previously approved these changes
Oct 9, 2024
|
I believe the practice is to put changelog entries in the |
sc68cal
reviewed
Oct 9, 2024
changelogs/changelog.yaml
Outdated
| 3.20.1: | ||
| changes: | ||
| minor_changes: | ||
| - Add example for using ansible variables in lookup (https://github.com/netbox-community/ansible_modules/pull/1332) |
There was a problem hiding this comment.
This needs to be created as a file in the fragments directory
There was a problem hiding this comment.
Thanks! I have added a fragment. Hope it looks better now :)
martbhell
force-pushed
the
nb_lookup_with_variable_example
branch
from
8afee20
to
fefd4da
Compare
Keeps the lookup files of v3.5 and v4.1 identical.
sc68cal
approved these changes
Oct 11, 2024
|
lgtm, waiting for other maintainers to weigh in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
New Behavior
...
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
Haven't seen this
"name" ~variablesyntax before.To speed up API lookups it's nice to use the filters rather than filtering with jinja.
...
Proposed Release Note Entry
...
Double Check
develbranch.