Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight Validation Fix #1069

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

danner26
Copy link
Member

In JSON Schema, multipleOf has issues with precision and specifically has a rounding issue. As mentioned in this jsonschema issue this can be fixed by using multipleOfPrecision. This PR implements that change, and closes issue #1068

@danner26 danner26 linked an issue Jan 26, 2023 that may be closed by this pull request
@danner26 danner26 self-assigned this Jan 26, 2023
@danner26 danner26 added status: under review A Pull Request (PR) or Issue that is current in review by a maintainer status: accepted and removed status: under review A Pull Request (PR) or Issue that is current in review by a maintainer labels Jan 26, 2023
@danner26 danner26 merged commit f16575d into netbox-community:master Jan 26, 2023
@danner26 danner26 deleted the schema-weight-fix branch January 26, 2023 15:52
@danner26 danner26 mentioned this pull request Jan 26, 2023
mjpereira602 pushed a commit to mjpereira602/devicetype-library that referenced this pull request Feb 22, 2023
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weight Validation
1 participant