dcim{,_related-connections}: added support for endpoint #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,3 +39,11 @@ type DeviceIdentifier struct { | |||
| ID int `json:"id"` | |||
| Name string `json:"name"` | |||
| } | |||
|
|
|||
| // SimpleIdentifier represents a simple thing that consists of only an id, name, | |||
There was a problem hiding this comment.
Make this uppercase ID for consistency with Go style.
There was a problem hiding this comment.
Nitpick: how about "object" instead of "thing"?
|
Add your name to the |
allanliu
force-pushed
the
feature/dcim_related-connections
branch
from
b122ffb to
854fd8f
Compare
| @@ -39,3 +39,11 @@ type DeviceIdentifier struct { | |||
| ID int `json:"id"` | |||
| Name string `json:"name"` | |||
| } | |||
|
|
|||
| // SimpleIdentifier represents a simple thing that consists of only an ID, name, | |||
There was a problem hiding this comment.
Change "thing" to "object".
allanliu
force-pushed
the
feature/dcim_related-connections
branch
from
854fd8f to
7ab428c
Compare
allanliu
force-pushed
the
feature/dcim_related-connections
branch
from
7ab428c to
45c50a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check :)