Update choices.py

[cyberndj]

Pull Request

Related Issue

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

Adding IP protocol to choice fields.
...

Double Check

• [x ] I have explained my PR according to the information in the comments
  or in a linked issue.
• [x ] My PR targets the dev branch.

Hi, this is for issue #142 to add IP as a protocol field. Please let me know if anything needs changed.

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 38.92%.

Quality metrics	Before	After	Change
Complexity	0.00 ⭐	0.00 ⭐	0.00
Method Length	144.00 😞	544.00 ⛔	400.00 👎
Working memory	6.00 ⭐	45.00 ⛔	39.00 👎
Quality	72.65% 🙂	33.73% 😞	-38.92% 👎

Other metrics	Before	After	Change
Lines	90	229	139

Changed files	Quality Before	Quality After	Quality Change
netbox_acls/choices.py	72.65% 🙂	33.73% 😞	-38.92% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[github-actions]

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[cyberndj]

Howdy,
I also added choice fields for IP/TCP/ICMP to help kickstart #136. I don't know Github enough to split commits across PRs, so apologies for dogpiling this one.
Thanks!
-Jake