Use slug validation for AccessList name #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a custom RegexValidator, the name of an access list can be validated using Django's slug validator. This reduces the overhead of a custom implementation and its testing. Additionally, this resolves an issue involving an invalid escape sequence in the related test case.
|
Hi @alehaa - thanks for the PR and for tackling the warning! I’m all for dropping the custom regex. To avoid any UI changes and an extra migration, could we keep |
|
I considered that, but since changing the validation also required a migration, it should be the same. However, I agree that this would be cleaner and will make the change. |
Although slug validation works for an access list name, the field should remain a CharField to clearly indicate its purpose. Using slug validation explicitly ensures that existing validation rules are used.
pheus
reviewed
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
None.
New Behavior
None
Contrast to Current Behavior
Instead of using a custom RegexValidator, the name of an access list can be validated using Django's slug validator. This resolves the following issue involving an invalid escape sequence in the related test case:
Discussion: Benefits and Drawbacks
This PR reduces the overhead of a custom implementation and its testing.
Changes to the Documentation
None
Proposed Release Note Entry
Address a syntax warning in the
AccessListtest cases.Double Check
devbranch.