Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI & CD #181

Merged
merged 3 commits into from
May 2, 2024
Merged

Use GitHub Actions for CI & CD #181

merged 3 commits into from
May 2, 2024

Conversation

LeoColomb
Copy link
Member

@LeoColomb LeoColomb commented Apr 17, 2024

This change would help to validate, test and release the chart.
It's using GitHub Actions and official Helm related workflows to automate the tasks.


Direct follow up of #162 (comment)

@RangerRick
Copy link
Contributor

Curious, what are the GPG bits for? I see it's half-commented-out, wasn't sure if there's some part of the workflow that wants it, or if it's vestigial from another version of this that you use.

@LeoColomb
Copy link
Member Author

@RangerRick It's a common setup to sign Helm charts https://helm.sh/docs/topics/provenance/.
That being said, none of this is yet configured for this chart, thus not available for use.
It's left as a usual best practice.

@RangerRick
Copy link
Contributor

I've gotta figure out some github access stuff, so I can't set up the signing bits yet, but for now this should merge as-is and I can uncomment that stuff when we're ready. Thanks for this!

@RangerRick RangerRick merged commit 90d5dd4 into netbox-community:develop May 2, 2024
1 check passed
@LeoColomb LeoColomb deleted the feat/gha branch May 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants