Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak YAML rendering using common render helpers #405

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Tweak YAML rendering using common render helpers #405

merged 3 commits into from
Dec 2, 2024

Conversation

LeoColomb
Copy link
Member

Tweak YAML rendering using common render helpers, and resolves #403.
Helps to reduce mistake surface in the rendering.

Also add extraEnvVarsCM and extraEnvVarsSecret as shortcuts to gather vars from CM or Secret directly.

@LeoColomb
Tweak YAML rendering using common render helpers
ef96b19 
Also add `extraEnvVarsCM` and `extraEnvVarsSecret` as shortcuts
to gather vars from CM or Secret directly.

Resolves #403
@LeoColomb LeoColomb requested a review from RangerRick November 1, 2024 11:28
@LeoColomb LeoColomb enabled auto-merge (squash) November 1, 2024 11:28
@NeodymiumFerBore
Copy link

NeodymiumFerBore commented Nov 1, 2024 •
edited
Loading

Thank you for implementing this so quickly!
Docstrings don't say that extraEnvVarsCM and extraEnvVarsSecret can be templated strings. Is it intentional?

@LeoColomb
Copy link
Member Author

@NeodymiumFerBore Not intentional, but the current state of docstring is far from perfection anyway.
I have a refresh in my to-do list, but keeping everything aligned and in sync with is a real pain.

RangerRick
RangerRick approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice to see all those annotations and stuff normalized.

Also the CM env vars is great.

@LeoColomb LeoColomb disabled auto-merge December 2, 2024 20:35
@LeoColomb LeoColomb enabled auto-merge (rebase) December 2, 2024 20:35
@LeoColomb LeoColomb merged commit 28fd016 into develop Dec 2, 2024
26 checks passed
@LeoColomb LeoColomb deleted the leo/fix/rendering branch December 2, 2024 20:53
@holmesb holmesb mentioned this pull request Dec 5, 2024
Closed
@bmhughes bmhughes mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render extraEnvs so it can be configured with templated values
3 participants
@LeoColomb @NeodymiumFerBore @RangerRick