Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change JSON schema sub-schemas to be relative #430

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: change JSON schema sub-schemas to be relative #430

merged 2 commits into from
Dec 5, 2024

Conversation

RangerRick
Copy link
Contributor

No description provided.

@RangerRick RangerRick force-pushed the ranger/fix-airgapped-schema-validation branch 12 times, most recently from e75ff5f to 935dbf2 Compare December 3, 2024 20:08
@RangerRick RangerRick marked this pull request as ready for review December 3, 2024 20:09
@RangerRick RangerRick enabled auto-merge December 3, 2024 20:09
@RangerRick RangerRick requested a review from LeoColomb December 3, 2024 20:09
@RangerRick RangerRick force-pushed the ranger/fix-airgapped-schema-validation branch 3 times, most recently from 0203a4e to f7bbc42 Compare December 3, 2024 20:25
@RangerRick RangerRick requested a review from bootc December 3, 2024 20:25
@RangerRick RangerRick force-pushed the ranger/fix-airgapped-schema-validation branch 3 times, most recently from 22939b1 to 834a560 Compare December 3, 2024 21:12
LeoColomb
LeoColomb requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion, wouldn't be way easier to drop the ref until the tool for rendering becomes compatible?

@RangerRick
Copy link
Contributor Author

@LeoColomb Yeah, I think I'll just change this commit to do that. It's "validating" configs for subcharts we recommend users disable anyway.

@RangerRick RangerRick force-pushed the ranger/fix-airgapped-schema-validation branch from 834a560 to 99fec62 Compare December 5, 2024 20:35
@RangerRick RangerRick merged commit 53026b0 into develop Dec 5, 2024
17 checks passed
@RangerRick RangerRick deleted the ranger/fix-airgapped-schema-validation branch December 5, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColomb LeoColomb LeoColomb approved these changes

@bootc bootc Awaiting requested review from bootc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RangerRick @LeoColomb