Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong types in values.schema.json #442

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix wrong types in values.schema.json #442

merged 4 commits into from
Dec 16, 2024

Conversation

devasmith
Copy link
Contributor

@devasmith devasmith commented Dec 11, 2024 •
edited by LeoColomb
Loading

Resolves #436

@devasmith devasmith mentioned this pull request Dec 11, 2024
Closed
@LeoColomb LeoColomb changed the title Fix wrong type userDnTemplate in values.schema.json Fix wrong types in values.schema.json Dec 11, 2024
LeoColomb
LeoColomb approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request, @devasmith.
LGTM

@RangerRick This PR changes the values types, it would require a major version bump. As for the beta, it needs to be merged with failing upgrade.

@RangerRick RangerRick merged commit 344f8be into netbox-community:develop Dec 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

userDnTemplate Type Mismatch Following Helm Upgrade
3 participants
@devasmith @LeoColomb @RangerRick