Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history limits in housekeeping cronjob #443

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

khushalmer03
Copy link
Contributor

@khushalmer03 khushalmer03 commented Dec 11, 2024

  • JobsHistoryLimits for housekeeping cronjob is not being passed correctly due to wrong fields in values.yaml
  • Corrected those values to match fields present in template of cronjob.

failedJobsHistoryLimit: {{ .Values.housekeeping.failedJobsHistoryLimit }}
schedule: {{ .Values.housekeeping.schedule | quote }}
successfulJobsHistoryLimit: {{ .Values.housekeeping.successfulJobsHistoryLimit }}

Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request, @khushalmer03.
Good catch, LGTM

@LeoColomb LeoColomb enabled auto-merge (squash) December 11, 2024 14:17
@LeoColomb LeoColomb changed the title Fix historylimits in housekeeping cronjob Fix history limits in housekeeping cronjob Dec 11, 2024
@LeoColomb LeoColomb merged commit 918e22e into netbox-community:develop Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants