Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml: fix volume mount options #1024

Merged

Conversation

florianschroen
Copy link
Contributor

New Behavior

fix volume mount options / prevent warning

Contrast to Current Behavior

z is valid only for bindmounts.

When using with volumes a warning for each volume appears:

$ docker compose up
[+] Building 0.0s (0/0)
 WARN[0000] mount of type `volume` should not define `bind` option
WARN[0000] mount of type `volume` should not define `bind` option
WARN[0000] mount of type `volume` should not define `bind` option
    
This may appear only when using a docker-compose.override.yml

Discussion: Benefits and Drawbacks

prevent warning

Changes to the Wiki

none

Proposed Release Note Entry

fixed volume mount options

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

tobiasge and others added 2 commits April 28, 2023 15:29
`z` is valid only for bindmounts

When using with volumes a warning for each volume appears:

netbox$ docker compose up
[+] Building 0.0s (0/0)
WARN[0000] mount of type `volume` should not define `bind` option
WARN[0000] mount of type `volume` should not define `bind` option
WARN[0000] mount of type `volume` should not define `bind` option

This may appear only when using a docker-compose.override.yml
@tobiasge tobiasge merged commit ebc5900 into netbox-community:develop Jun 15, 2023
@tobiasge tobiasge mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants