Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose file version line obsolete issue fix #1193

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

kchandan
Copy link

@kchandan kchandan commented Apr 1, 2024

Related Issue:

New Behavior

Docker has made the version line obsolete. When following the documentation step and doing docker compose is throwing error.

:~/netbox-docker$ docker compose pull
WARN[0000] ~/netbox-docker/docker-compose.yml: `version` is obsolete
WARN[0000] !/netbox-docker/docker-compose.override.yml: `version` is obsolete

Contrast to Current Behavior

Once this line removal the docker compose pull works well. Updated the readme as well.

sudo docker compose pull
[+] Pulling 26/26
 ✔ redis-cache Skipped - Image is already being pulled by redis                                                                                                                                             0.0s
 ✔ netbox-worker Skipped - Image is already being pulled by netbox                                                                                                                                          0.0s
 ✔ netbox-housekeeping Skipped - Image is already being pulled by netbox                                                                                                                                    0.0s
 ✔ netbox 14 layers [⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿]      0B/0B      Pulled                                                                                                                                                11.9s
   ✔ 6360b3717211 Pull complete                                                                                                                                                                             0.9s
   ✔ 060f062dc86e Pull complete                                                                                                                                                                             1.3s
   ✔ 8853789ea8ce Pull complete                                                                                                                                                                             2.0s
   ✔ 9240c968ff32 Pull complete                                                                                                                                                                             2.0s
   ✔ dc96838c65a9 Pull complete                                                                                                                                                                             1.7s
   ✔ b05dedc9a602 Pull complete                                                                                                                                                                             2.3s
   ✔ 79a476309480 Pull complete                                                                                                                                                                             2.6s
   ✔ c3a38d8d724d Pull complete                                                                                                                                                                             2.3s
   ✔ dec94c5855b3 Pull complete                                                                                                                                                                             2.6s
   ✔ 67cda12f9041 Pull complete                                                                                                                                                                             2.6s
   ✔ 8a4649e22240 Pull complete                                                                                                                                                                             2.8s
   ✔ d6f9dc02592c Pull complete                                                                                                                                                                             2.8s
   ✔ 4f4fb700ef54 Pull complete                                                                                                                                                                             2.9s
   ✔ d0e38cc0d313 Pull complete                                                                                                                                                                             3.3s
 ✔ redis 7 layers [⣿⣿⣿⣿⣿⣿⣿]      0B/0B      Pulled                                                                                                                                                          5.2s
   ✔ 4abcf2066143 Pull complete                                                                                                                                                                             3.2s
   ✔ 5c3180d10209 Pull complete                                                                                                                                                                             3.2s
   ✔ f76326fd8e6b Pull complete                                                                                                                                                                             3.5s
   ✔ 034c076ba1e7 Pull complete                                                                                                                                                                             3.5s
   ✔ dffcad17539b Pull complete                                                                                                                                                                             3.9s
   ✔ 5913474e0f39 Pull complete                                                                                                                                                                             3.8s
   ✔ cc6fccbbefa3 Pull complete    

...

Discussion: Benefits and Drawbacks

...

Changes to the Wiki

...

Proposed Release Note Entry

...

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@kchandan kchandan changed the title Docker version Docker compose file version line obsolete issue fix Apr 1, 2024
Copy link

@padthaitofuhot padthaitofuhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says it does and removes the version tag from docker-compose.yml, the README, and related files.

As of Docker Compose 1.27, the version tag is deprecated. Since the Docker Compose version required for this project is already 1.28.0, I can think of no reason block this change.

@tobiasge tobiasge enabled auto-merge April 4, 2024 13:41
@tobiasge tobiasge merged commit 5309673 into netbox-community:develop Apr 4, 2024
9 checks passed
@kchandan kchandan deleted the docker-version branch April 4, 2024 17:24
@kchandan kchandan restored the docker-version branch April 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants