Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'ttf-ubuntu-font-family' from image #514

Merged
merged 1 commit into from
May 18, 2021

Conversation

tobiasge
Copy link
Member

Related Issue: -

New Behavior

  • Image based on alpine:edge is building correctly

Contrast to Current Behavior

  • Build fails for alpine:edge

Discussion: Benefits and Drawbacks

  • The packages 'ttf-ubuntu-font-family' was removed from Alpine Linux

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Because the package ttf-ubuntu-font-family was removed from Alpine Linux, it won't be installed into the image anymore.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge
Copy link
Member Author

tobiasge commented May 18, 2021

@cimnine Do you know why we installed the ttf-ubuntu-font-family package in the first place? Do we need a replacement?

@tobiasge tobiasge changed the base branch from release to develop May 18, 2021 07:45
@cimnine
Copy link
Collaborator

cimnine commented May 18, 2021

It might once have been required to render certain things in NetBox I suppose. Not sure. It does kot seem to be required for NetBox though, so we can kick it.

@tobiasge tobiasge merged commit c49fa31 into netbox-community:develop May 18, 2021
@tobiasge tobiasge deleted the ttf-ubuntu branch May 18, 2021 12:40
@cimnine cimnine added this to the next milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants