Initialize tenants before sites #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlemesh
changed the title
cimnine
approved these changes
Jun 3, 2021
cimnine
changed the title
|
Thank you for this PR – it is much appreciated. I know that it can be frustrating when you have to wait for a PR to be reviewed / merged. But please know that this project is managed by volunteers who do have day-jobs, families and other hobbies. I therefore ask you to have a little more patience next time around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Sites can have Tenants but you can't initialise sites with tenants because tenants startup script runs after sites. This PR allows Sites initialization with associated Tenant.
...
Contrast to Current Behavior
Startup scripts run order changed to:
-> run tenant groups (prerequisite for tenants)
-> run tenants
-> run sites
...
Discussion: Benefits and Drawbacks
Allows functionality that should be here by design. I can't see any drawbacks.
...
Changes to the Wiki
No changes required.
...
Proposed Release Note Entry
Startup scripts run order changed to: tenant groups, tenants, sites.
...
Double Check
developbranch.