Publish image to GitHub Container Registry #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
added
the
enhancement
tobiasge
approved these changes
Oct 18, 2021
cimnine
changed the title
|
This was merged, but the images have not been yet made public. |
|
It's not yet released. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
New Behavior
I've extracted this from #604.
Contrast to Current Behavior
We only publish to quay.io and docker.io. But GitHub's container registry has a nice integration into GitHub, which is the home of NetBox Docker.
Discussion: Benefits and Drawbacks
I don't see no drawback, since we rely on GitHub anyway. I do see as advantage that we'd have one more fallback solution in place. Docker is now rate-limited and who knows what Red Hat plans with Quay. (To be fair, the same could be said for GHCR, but at least (hopefully) did GitHub already know what they put themselves into when they launched GHCR.)
Changes to the Wiki
none
Proposed Release Note Entry
NetBox Docker is now also published to GitHub's Container Registry:
docker pull ghcr.io/netbox-community/netbox.Double Check
developbranch.