-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup & Reorg startup scripts #691
Cleanup & Reorg startup scripts #691
Conversation
mypy linting does not like the below: 53: else:
54: query = {field: params.pop(assoc)} # 290_ip_addresses.py:54: error: Dict entry 0 has incompatible type "Optional[str]": "Any"; expected "str": "Any"
55: params[assoc] = model.objects.get(**query) # 290_ip_addresses.py:56: error: Item "None" of "Optional[Any]" has no attribute "objects" It seems I am triggering the linting because I moved the file. I likely need some assistance with this failure. |
I currently don't have capacity to look into it. But as it's not your fault, don't worry about it. We will be able to merge even with this inconvenience. What troubles me more is that the test does not run through. # Build latest
./build.sh master
# Test latest
./test.sh latest Tipp: I often commented out the section in the |
I appreciate the hand holding on this @cimnine |
* Cleanup & Reorg startup scripts
Related Issue: #669
New Behavior
Reorder startup scrips & delete duplicate scripts
Contrast to Current Behavior
Duplicate scripts run
Discussion: Benefits and Drawbacks
remove duplicated scripts, and enforce script order
Changes to the Wiki
N/A
Proposed Release Note Entry
Startup Scripts reorganization & cleanup
Double Check
develop
branch.