Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & Reorg startup scripts #691

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Cleanup & Reorg startup scripts #691

merged 7 commits into from
Feb 3, 2022

Conversation

ryanmerolle
Copy link
Contributor

Related Issue: #669

New Behavior

Reorder startup scrips & delete duplicate scripts

Contrast to Current Behavior

Duplicate scripts run

Discussion: Benefits and Drawbacks

remove duplicated scripts, and enforce script order

Changes to the Wiki

N/A

Proposed Release Note Entry

Startup Scripts reorganization & cleanup

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@ryanmerolle
Copy link
Contributor Author

mypy linting does not like the below:

53:            else:
54:                query = {field: params.pop(assoc)}  # 290_ip_addresses.py:54: error: Dict entry 0 has incompatible type "Optional[str]": "Any"; expected "str": "Any"
55:                params[assoc] = model.objects.get(**query)  # 290_ip_addresses.py:56: error: Item "None" of "Optional[Any]" has no attribute "objects"

It seems I am triggering the linting because I moved the file. I likely need some assistance with this failure.

.gitignore Outdated Show resolved Hide resolved
@cimnine
Copy link
Collaborator

cimnine commented Feb 2, 2022

It seems I am triggering the linting because I moved the file. I likely need some assistance with this failure.

I currently don't have capacity to look into it. But as it's not your fault, don't worry about it. We will be able to merge even with this inconvenience.

What troubles me more is that the test does not run through.
Did it work when you tried it locally? From memory, I believe you can invoke it like this:

# Build latest
./build.sh master

# Test latest
./test.sh latest

Tipp: I often commented out the section in the test.sh where it runs NetBox's own unit tests when I developed on the initializers. Otherwise the test goes on forever.

@ryanmerolle
Copy link
Contributor Author

I appreciate the hand holding on this @cimnine

@cimnine cimnine requested a review from tobiasge February 3, 2022 15:57
@cimnine cimnine added maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. bug This issue describes a confirmed bug. and removed maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. labels Feb 3, 2022
@tobiasge tobiasge merged commit 8860d32 into netbox-community:develop Feb 3, 2022
@tobiasge tobiasge mentioned this pull request Feb 21, 2022
ITJamie pushed a commit to ITJamie/netbox-docker that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants