Add support for DeviceType components #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr3ator
force-pushed
the
feature/device_type_components
branch
2 times, most recently
from
5eecfc6
to
cdd9d54
Compare
|
This PR assumes that #729 is merged, until then the build pipelines will fail. |
cimnine
added
the
enhancement
cimnine
requested changes
Apr 8, 2022
There was a problem hiding this comment.
Thank you for this PR. Just one tiny remark:
Since the examples are mostly our reference documentation, I believe it would be great to have one entry where the following is true and then a comment explaining that the non-template field takes presedence.
… if by mistake name and name_template keys are provided then the normal field takes precedence.
kr3ator
force-pushed
the
feature/device_type_components
branch
from
1df9b36
to
12753dd
Compare
|
@tobiasge are we good to merge this and my other 2 PRs ? |
kr3ator
force-pushed
the
feature/device_type_components
branch
from
a1ecfce
to
12753dd
Compare
Merged
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
New Behavior
This PR adds support for all of the DeviceType components like Interfaces, DeviceBays, etc. to the 190_device_type startup script.
Contrast to Current Behavior
Currently there is no support for DeviceType components and there is only startup script that is available to create actual instances of these components is for interfaces.
Discussion: Benefits and Drawbacks
This is backwards compatible. If a user wants to use this feature he only needs to extend his current device_type.yml (examples therein).
Templates are supported just as when adding a component through the UI. Fields that support templating need to be suffixed with _template, e.g. name_template. If by mistake name and name_template keys are provided then the normal field takes precedence.
This PR assumes that #729 is merged.
Changes to the Wiki
n/a
Proposed Release Note Entry
Feature: Add support for device component templates to DeviceType startup script.
Double Check
developbranch.