Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added start_period to docker-compose example #913

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Added start_period to docker-compose example #913

merged 2 commits into from
Jan 4, 2023

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Jan 3, 2023

Related Issue: #907

New Behavior

  • Extended example docker-compose file

Contrast to Current Behavior

  • No explanation for start_period was present

Discussion: Benefits and Drawbacks

  • Helps to understand the settings better

Changes to the Wiki

  • Same explanation could be added to the Troubleshooting section

Proposed Release Note Entry

  • Extended example docker-compose file

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine January 3, 2023 14:01
cimnine
cimnine approved these changes Jan 3, 2023
View reviewed changes
docker-compose.override.yml.example Outdated Show resolved Hide resolved
docker-compose.override.yml.example
# subsequent starts. For the first start after major version upgrades of Netbox
# the start_period might also need to be set higher.
# Default value in our docker-compose.yml is 60s
start_period: 90s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also set it higher for our default config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to leave the default as it is, docker-compose will wait to start the other containers until the start_period is over.

@tobiasge @cimnine
Update docker-compose.override.yml.example
0c1b69d 
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
@tobiasge tobiasge merged commit ff37e17 into netbox-community:develop Jan 4, 2023
@tobiasge tobiasge deleted the start_period_explanation branch January 4, 2023 08:27
@tobiasge tobiasge mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine