Preparation for Netbox 3.5 #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
approved these changes
Apr 18, 2023
tobiasge
force-pushed
the
prepare-for-nb-35
branch
3 times, most recently
from
2ce7c02
to
cbf0a97
Compare
- Reports and Scripts have changed in Netbox 3.5. They need to be uploaded now. The Docker compose now creates a volume as it does for the media files - Napalm has been removed from Netbox 3.5 All configuration entries for Napalm were removed and napalm itself is removed from the requirements file - Removed Gunicorn from the image Nginx Unit has been used for a while now. No need to install Gunicorn
Setting the BASE_PATH is a more involved process than just setting this variable. To prevent surprises the option to set this via ENV variable was removed.
tobiasge
force-pushed
the
prepare-for-nb-35
branch
from
cbf0a97
to
858611a
Compare
tobiasge
force-pushed
the
prepare-for-nb-35
branch
from
b00dd37
to
7532508
Compare
cimnine
reviewed
Apr 28, 2023
cimnine
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: -
New Behavior
Docker compose now creates volumes as it does for the media files.
All configuration entries for Napalm were removed and napalm itself is removed from the requirements file
Nginx Unit has been used for a while now. No need to install Gunicorn
Changing the BASE_PATH needs more than just setting the variable. To prevent issues it's no longer allowed to change it that easily.
Netbox requires a SECRET_KEY with a minimum of 50 characters in version 3.5 and up
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
Changes to the Wiki
Proposed Release Note Entry
Double Check
developbranch.