Add e2e tests for Prefix #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
requested review from
alexandernorth,
jstudler,
faebr and
bruelea
henrybear327
force-pushed
the
demo/e2e_tests
branch
7 times, most recently
from
2d80bf7 to
f0beacd
Compare
|
The happy path written are
|
henrybear327
force-pushed
the
demo/e2e_tests
branch
2 times, most recently
from
4ca1f10 to
a299551
Compare
|
The e2e test run is consistently running around 8.5 min (https://github.com/netbox-community/netbox-operator/actions/runs/12273670479/job/34244939819?pr=161) The main time is spent on setting things up... |
henrybear327
force-pushed
the
demo/e2e_tests
branch
3 times, most recently
from
62c84ed to
458cfb2
Compare
|
@bruelea commented that we shouldn't load demo data for e2e tests |
This is a lot more work than expected, since we need to extract the minimal tables to set up, etc. Propose to have it done in a follow-up PR. WDYT? Thanks |
henrybear327
force-pushed
the
demo/e2e_tests
branch
from
c6692ee to
7217ad1
Compare
henrybear327
force-pushed
the
demo/e2e_tests
branch
from
7217ad1 to
275a9af
Compare
bruelea
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging Chainsaw, we can easily write e2e tests for the NetBox operator, testing directly against the NetBox instance
This PR focuses solely on the Prefix and PrefixClaim, happy path.
Implements #163