Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header lint rules #60

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

henrybear327
Copy link
Collaborator

@henrybear327 henrybear327 commented Sep 13, 2024

Making sure that the header is properly added

@henrybear327 henrybear327 self-assigned this Sep 13, 2024
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from d607718 to 9fbeb4e Compare September 13, 2024 11:14
@henrybear327 henrybear327 marked this pull request as draft September 13, 2024 11:14
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from 9fbeb4e to d61c671 Compare September 13, 2024 11:19
Base automatically changed from ci/add_linter to main September 17, 2024 07:06
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from d61c671 to 9e4f0cf Compare September 17, 2024 08:21
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from 9e4f0cf to 1de91a3 Compare October 7, 2024 12:32
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from 1de91a3 to 7e4aa5b Compare November 11, 2024 09:24
@henrybear327 henrybear327 marked this pull request as ready for review November 11, 2024 09:50
@henrybear327
Copy link
Collaborator Author

@jstudler I think we can merge this for now, as our conclusion regarding license header compliance basically dictates that we need to have an Apache license on top of all source files in all source files.

WDYT?

@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from 7e4aa5b to b03d7f8 Compare November 11, 2024 09:53
@henrybear327 henrybear327 removed the request for review from bruelea November 11, 2024 09:53
@henrybear327 henrybear327 force-pushed the ci/add_license_header_lint branch from b03d7f8 to 111b53c Compare November 11, 2024 12:38
@henrybear327 henrybear327 merged commit 11c4c5f into main Nov 11, 2024
5 checks passed
@henrybear327 henrybear327 deleted the ci/add_license_header_lint branch December 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants