Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPv6 #74

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Add support for IPv6 #74

merged 7 commits into from
Sep 30, 2024

Conversation

bruelea
Copy link
Collaborator

@bruelea bruelea commented Sep 24, 2024

changes:

  • edit validation rule for ip addresses and prefixes in the CRD definition to allow IPv6
  • in the controllers the leaselock name was replaced by the parentprefix in the logs about leaselocker
  • add the update the status conditions if the assignment of a prefix/ipaddress fails in the claim controllers
  • make the "github.com/netbox-community/netbox-operator/pkg/netbox/api" package compatible with IPv6 and update the tests
  • remove unused function

@bruelea bruelea self-assigned this Sep 24, 2024
@bruelea bruelea force-pushed the feature/support-ipv6-reservation branch from 0d22757 to eaa8366 Compare September 24, 2024 13:10
api/v1/prefixclaim_types.go Outdated Show resolved Hide resolved
config/crd/bases/netbox.dev_prefixclaims.yaml Outdated Show resolved Hide resolved
@henrybear327 henrybear327 force-pushed the feature/support-ipv6-reservation branch from 3c85251 to 4d448c3 Compare September 24, 2024 17:41
@henrybear327 henrybear327 self-requested a review September 26, 2024 21:53
@henrybear327 henrybear327 force-pushed the feature/support-ipv6-reservation branch 2 times, most recently from 3943f8d to 9ff1212 Compare September 26, 2024 21:57
Copy link
Collaborator

@henrybear327 henrybear327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general :) Great job @bruelea

internal/controller/prefixclaim_controller.go Outdated Show resolved Hide resolved
pkg/netbox/api/ip_address_claim_test.go Show resolved Hide resolved
pkg/netbox/api/prefix_claim.go Outdated Show resolved Hide resolved
pkg/netbox/api/prefix_claim.go Outdated Show resolved Hide resolved
pkg/netbox/api/prefix_claim_test.go Outdated Show resolved Hide resolved
pkg/netbox/api/prefix_claim_test.go Outdated Show resolved Hide resolved
pkg/netbox/api/prefix_claim_test.go Outdated Show resolved Hide resolved
pkg/netbox/api/ip_address_claim_test.go Outdated Show resolved Hide resolved
pkg/netbox/api/ip_address_claim_test.go Outdated Show resolved Hide resolved
pkg/netbox/api/ip_address_claim_test.go Outdated Show resolved Hide resolved
@bruelea bruelea force-pushed the feature/support-ipv6-reservation branch 2 times, most recently from a7a2764 to 81fbe16 Compare September 27, 2024 13:26
@bruelea
Copy link
Collaborator Author

bruelea commented Sep 27, 2024

LGTM in general :) Great job @bruelea

Thanks, for the feedback! @henrybear327. I edited the code accordingly and changed the error handling in the claim controllers to requeue the object if the assignment fails and not returning an error.

Copy link
Collaborator

@henrybear327 henrybear327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small tweaks! Thanks for addressing the comments @bruelea!

pkg/netbox/api/ip_address_claim_test.go Outdated Show resolved Hide resolved
internal/controller/prefixclaim_controller.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrybear327 henrybear327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) Thanks @bruelea

(and nice catch on the spelling error :D)

@bruelea bruelea force-pushed the feature/support-ipv6-reservation branch from 26f3cc1 to eea770e Compare September 30, 2024 12:43
bruelea and others added 2 commits September 30, 2024 14:56
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
@bruelea bruelea force-pushed the feature/support-ipv6-reservation branch from eea770e to 593568c Compare September 30, 2024 13:04
@bruelea bruelea merged commit b869d23 into main Sep 30, 2024
5 checks passed
@henrybear327 henrybear327 deleted the feature/support-ipv6-reservation branch September 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants