-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IPv6 #74
Conversation
0d22757
to
eaa8366
Compare
3c85251
to
4d448c3
Compare
3943f8d
to
9ff1212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general :) Great job @bruelea
a7a2764
to
81fbe16
Compare
Thanks, for the feedback! @henrybear327. I edited the code accordingly and changed the error handling in the claim controllers to requeue the object if the assignment fails and not returning an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small tweaks! Thanks for addressing the comments @bruelea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :) Thanks @bruelea
(and nice catch on the spelling error :D)
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
26f3cc1
to
eea770e
Compare
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
eea770e
to
593568c
Compare
changes: