Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Finalizers #78

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fix Finalizers #78

merged 3 commits into from
Oct 8, 2024

Conversation

MaIT-HgA
Copy link
Contributor

@MaIT-HgA MaIT-HgA commented Sep 30, 2024 •
edited
Loading

Changes:

  • adding Finalizers are moved up
  • IP/Prefix deletion functions are updated with not found errors
  • error handling in Finalizers is updated with not found errors
  • integration test is updated

Close #77

@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 3 times, most recently from 9b2fc00 to a1f57ac Compare September 30, 2024 11:37
@MaIT-HgA MaIT-HgA self-assigned this Sep 30, 2024
@MaIT-HgA MaIT-HgA added the bug Something isn't working label Sep 30, 2024
@MaIT-HgA MaIT-HgA marked this pull request as ready for review September 30, 2024 12:02
@henrybear327 henrybear327 removed their request for review October 1, 2024 07:49
jstudler
jstudler reviewed Oct 1, 2024
View reviewed changes
pkg/netbox/api/prefix.go Outdated Show resolved Hide resolved
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 6786ac5 to b3b971a Compare October 7, 2024 12:50
bruelea
bruelea requested changes Oct 7, 2024
View reviewed changes
internal/controller/expected_netboxmock_calls_test.go Outdated Show resolved Hide resolved
internal/controller/expected_netboxmock_calls_test.go Outdated Show resolved Hide resolved
internal/controller/ipaddress_controller_test.go Outdated Show resolved Hide resolved
internal/controller/netbox_testdata_test.go Outdated Show resolved Hide resolved
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 7c9743a to 5f41060 Compare October 8, 2024 06:34
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 7c1c8e6 to 77b6314 Compare October 8, 2024 06:54
@MaIT-HgA MaIT-HgA merged commit 064e6b5 into main Oct 8, 2024
5 checks passed
@MaIT-HgA MaIT-HgA deleted the fix/finalizers branch October 8, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstudler jstudler jstudler left review comments

@bruelea bruelea bruelea approved these changes

@faebr faebr Awaiting requested review from faebr

Assignees

@MaIT-HgA MaIT-HgA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalizer set too late
3 participants
@MaIT-HgA @jstudler @bruelea