Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Save filters #160

Closed
dreng opened this issue Sep 16, 2022 · 4 comments · Fixed by #227
Closed

Feature: Save filters #160

dreng opened this issue Sep 16, 2022 · 4 comments · Fixed by #227
Assignees
@mattieserver
Labels
status: accepted This issue has been accepted for implementation type: feature Request for new feature or change to existing feature

Comments

@dreng
Copy link
Collaborator

dreng commented Sep 16, 2022

It would be handy to be able to save different filter settings for later use.
@dreng
Copy link
Collaborator Author

dreng commented Sep 25, 2022

This is on the NetBox roadmap for v3.4 already. See netbox-community/netbox#9623. The implementation should be a piece of cake after v3.4 has been released.

@dreng dreng added the type: feature Request for new feature or change to existing feature label Dec 10, 2022
@dreng
Copy link
Collaborator Author

dreng commented Dec 22, 2022

As NetBox v3.4.1 is out, we are able to implement saved filters now.

@dreng dreng added status: accepted This issue has been accepted for implementation status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 22, 2022
@mattieserver
Copy link
Collaborator

I upgraded my Dev instance but did not see the saved filters show up when using the plugin. Will have to see if we need to make any changes.

@dreng
Copy link
Collaborator Author

dreng commented Dec 22, 2022

Will have to see if we need to make any changes.

We need to make changes for sure. I've had a look into it before. We must at least change the template. Unfortunately, there is one passage that I have not yet figured out. That's why I haven't yet assigned the issue to myself.

@mattieserver mattieserver removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Dec 23, 2022
@mattieserver mattieserver self-assigned this Dec 23, 2022
@mattieserver mattieserver linked a pull request Dec 23, 2022 that will close this issue
Closes #160: feature save filters #227
Merged
mattieserver added a commit that referenced this issue Dec 26, 2022
@mattieserver
Closes #160: feature save filters (#227)
e0bd1d4 
* initial saved filter support

* add filter field

* fixed model

* changed margin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattieserver mattieserver

Labels
status: accepted This issue has been accepted for implementation type: feature Request for new feature or change to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #160: feature save filters netbox-community/netbox-topology-views
2 participants
@mattieserver @dreng