Netbox 4.2.3

[tonnymn]

NetBox version

v4.2.3

Topology Views version

v4.2.0

Steps to Reproduce

topology viewer 4.2.3 cannot run on netbox 4.2.3. on docker

Expected Behavior

Plugin to run

Observed Behavior

🧬 loaded config '/etc/netbox/config/configuration.py'
🧬 loaded config '/etc/netbox/config/extra.py'
🧬 loaded config '/etc/netbox/config/logging.py'
🧬 loaded config '/etc/netbox/config/plugins.py'
Traceback (most recent call last):
File "/opt/netbox/netbox/./manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/opt/netbox/venv/lib/python3.12/site-packages/django/core/management/init.py", line 442, in execute_from_command_line
utility.execute()
File "/opt/netbox/venv/lib/python3.12/site-packages/django/core/management/init.py", line 416, in execute
django.setup()
File "/opt/netbox/venv/lib/python3.12/site-packages/django/init.py", line 24, in setup
apps.populate(settings.INSTALLED_APPS)
File "/opt/netbox/venv/lib/python3.12/site-packages/django/apps/registry.py", line 124, in populate
app_config.ready()
File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_topology_views/init.py", line 22, in ready
super().ready()
File "/opt/netbox/netbox/netbox/plugins/init.py", line 116, in ready
if template_extensions := self._load_resource('template_extensions'):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/netbox/netbox/netbox/plugins/init.py", line 92, in _load_resource
module = import_module(default_module)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/importlib/init.py", line 90, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1387, in _gcd_import
File "", line 1360, in _find_and_load
File "", line 1331, in _find_and_load_unlocked
File "", line 935, in _load_unlocked
File "", line 995, in exec_module
File "", line 488, in _call_with_frames_removed
File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_topology_views/template_content.py", line 6, in
NETBOX_CURRENT_VERSION = version.parse(settings.VERSION)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/packaging/version.py", line 56, in parse
return Version(version)
^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/packaging/version.py", line 202, in init
raise InvalidVersion(f"Invalid version: {version!r}")
packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'

[JeanKean-art]

Hello, same issue on same version on my side ;)

[cruse1977]

This appears to be docker changing the version string on 4.2.3 images - its not a bug in topology views and impacts anything using version.parse(settings.VERSION)

v4.2.3:

`>>> from django.conf import settings

print(version.parse(settings.VERSION))
Traceback (most recent call last):
File "/usr/lib/python3.12/code.py", line 90, in runcode
exec(code, self.locals)
File "", line 1, in
File "/opt/netbox/venv/lib/python3.12/site-packages/packaging/version.py", line 56, in parse
return Version(version)
^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/packaging/version.py", line 202, in init
raise InvalidVersion(f"Invalid version: {version!r}")
packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'
`

vs 4.2.2

`>>> from django.conf import settings

from packaging import version
print(version.parse(settings.VERSION))
4.2.2`

[cruse1977]

netbox-community/netbox-docker#1398

[tobiasge]

In this PR netbox-community/netbox#15908 NetBox changed the VERSION handling. Since that PR VERSION can contain more that just the version number. The raw version number can be found in RELEASE.version.

I opened a PR to fix this: #608

[cruse1977]

Thanks Tobias - they introduced this last week ..

[aparcar]

If you're using Docker to deploy Netbox the following Dockerfile-Plugins may help

FROM netboxcommunity/netbox:latest

COPY ./plugin_requirements.txt /opt/netbox/
RUN mkdir -p /opt/netbox/netbox/static/netbox_topology_views/img
RUN /usr/local/bin/uv pip install -r /opt/netbox/plugin_requirements.txt

COPY configuration/configuration.py /etc/netbox/config/configuration.py
COPY configuration/plugins.py /etc/netbox/config/plugins.py

RUN sed -i 's/NETBOX_CURRENT_VERSION = version.parse(settings.VERSION)/NETBOX_CURRENT_VERSION = version.parse(settings.RELEASE.version)/' \
    /opt/netbox/venv/lib/python3.12/site-packages/netbox_topology_views/template_content.py

# NOTE: This SECRET_KEY is only used during the installation. There's no need to change it.
RUN DEBUG="true" SECRET_KEY="dummydummydummydummydummydummydummydummydummydummy" \
    /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input

[sebrhex]

According to https://github.com/netbox-community/netbox-topology-views/releases/tag/v4.2.1 this should be fixed with #608