Skip to content

Commit

Permalink
Closes #10604: Remove unused extra_tabs block from object.html generi…
Browse files Browse the repository at this point in the history
…c template
  • Loading branch information
jeremystretch committed Feb 20, 2023
1 parent 24e26b9 commit e499b01
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion docs/plugins/development/templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ This template is used by the `ObjectView` generic view to display a single objec
| `breadcrumbs` | - | Breadcrumb list items (HTML `<li>` elements) |
| `object_identifier` | - | A unique identifier (string) for the object |
| `extra_controls` | - | Additional action buttons to display |
| `extra_tabs` | - | Additional tabs to include |

#### Context

Expand Down
3 changes: 2 additions & 1 deletion docs/release-notes/version-3.5.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# NetBox v3.4
# NetBox v3.5

## v3.5.0 (FUTURE)

### Other Changes

* [#10604](https://github.com/netbox-community/netbox/issues/10604) - Remove unused `extra_tabs` block from `object.html` generic template
* [#10923](https://github.com/netbox-community/netbox/issues/10923) - Remove unused `NetBoxModelCSVForm` class (replaced by `NetBoxModelImportForm`)
4 changes: 0 additions & 4 deletions netbox/templates/generic/object.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
breadcrumbs: Breadcrumb list items (HTML <li> elements)
object_identifier: Unique identifier for the object
extra_controls: Additional action buttons to display
extra_tabs: Additional tabs to include
content: Page content

Context:
Expand Down Expand Up @@ -84,9 +83,6 @@
<a class="nav-link{% if not tab %} active{% endif %}" href="{{ object.get_absolute_url }}">{{ object|meta:"verbose_name"|bettertitle }}</a>
</li>

{# Include any extra tabs passed by the view #}
{% block extra_tabs %}{% endblock %}

{# Include tabs for registered model views #}
{% model_view_tabs object %}
</ul>
Expand Down

0 comments on commit e499b01

Please sign in to comment.