Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeLog false positive for wwn #10294

Closed
jiuka opened this issue Sep 8, 2022 · 0 comments · Fixed by #10296
Closed

ChangeLog false positive for wwn #10294

jiuka opened this issue Sep 8, 2022 · 0 comments · Fixed by #10296
Assignees
@kkthxbye-code
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jiuka
Copy link

jiuka commented Sep 8, 2022

NetBox version

v3.3.2

Python version

3.8

Steps to Reproduce

  1. Update a Interface
  2. Display the generated change log.

Expected Behavior

Only changed properties are detected as changed.

Observed Behavior

wwn is detected as a changed from null to ""
@jiuka jiuka added the type: bug A confirmed report of unexpected behavior in the application label Sep 8, 2022
@kkthxbye-code kkthxbye-code added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Sep 8, 2022
@kkthxbye-code kkthxbye-code self-assigned this Sep 8, 2022
@kkthxbye-code kkthxbye-code added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 8, 2022
@kkthxbye-code kkthxbye-code mentioned this issue Sep 8, 2022
Merged
jeremystretch added a commit that referenced this issue Sep 8, 2022
@jeremystretch
Merge pull request #10296 from kkthxbye-code/10294-fix-wwn-changelog
a7562a6 
Fixes #10294 - Don't return empty string for empty wwn form field
jeremystretch added a commit that referenced this issue Sep 8, 2022
@jeremystretch
Changelog for #10250, #10294
385a0f9
@arthanson arthanson mentioned this issue Sep 15, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kkthxbye-code kkthxbye-code

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10294 - Don't return empty string for empty wwn form field kkthxbye-code/netbox
2 participants
@kkthxbye-code @jiuka