Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Field Not Redering in UI in L2VPN Terminations #10362

Closed
kvedder-amplex opened this issue Sep 14, 2022 · 3 comments · Fixed by #10370
Closed

Custom Field Not Redering in UI in L2VPN Terminations #10362

kvedder-amplex opened this issue Sep 14, 2022 · 3 comments · Fixed by #10370
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@kvedder-amplex
Copy link
Contributor

NetBox version

v3.3.1

Python version

3.8

Steps to Reproduce

  1. Create a custom field, assign it to the L2VPNTermination Model. I tried "text" and "object".

Expected Behavior

I expected to be able to edit the custom field in the UI.

Observed Behavior

The custom field doesn't appear in the UI. It does appear in the API. I did not see this fixed in 3.3.2, as best I can tell.

image

    "count": 1,
    "next": null,
    "previous": null,
    "results": [
        {
            "id": 1,
            "url": "https://***REDACTED***/api/ipam/l2vpn-terminations/1/",
            "display": "ce51 <> car3-wireless",
            "l2vpn": {
                "id": 1,
                "url": "https://***REDACTED***/api/ipam/l2vpns/1/",
                "display": "car3-wireless",
                "identifier": null,
                "name": "car3-wireless",
                "slug": "car3-wireless",
                "type": "vpls"
            },
            "assigned_object_type": "dcim.interface",
            "assigned_object_id": 119,
            "assigned_object": {
                "id": 119,
                "url": "https://***REDACTED***/api/dcim/interfaces/119/",
                "display": "ce51",
                "device": {
                    "id": 5,
                    "url": "https://***REDACTED***/api/dcim/devices/5/",
                    "display": "hq-core-02",
                    "name": "hq-core-02"
                },
                "name": "ce51",
                "cable": null,
                "_occupied": false
            },
            "tags": [],
            "custom_fields": {
                "service_template": null
            },
            "created": "2022-09-14T14:39:07.664945Z",
            "last_updated": "2022-09-14T14:39:07.664966Z"
        }
    ]
} ```
@kvedder-amplex kvedder-amplex added the type: bug A confirmed report of unexpected behavior in the application label Sep 14, 2022
@kvedder-amplex
Copy link
Contributor Author

I think #5509 may have caught this, and may prevent this in the future?

@DanSheps
Copy link
Member

I don't think it will catch it completely.

This is likely because we use a custom form on the termination edit to handle the various different types of terminations.

@DanSheps DanSheps added the status: accepted This issue has been accepted for implementation label Sep 14, 2022
@DanSheps DanSheps self-assigned this Sep 14, 2022
@kvedder-amplex
Copy link
Contributor Author

Yeah I am putting in a PR right now. I think netbox/templates/ipam/l2vpntermination_edit.html is missing the code to render the custom fields.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants