Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons to edit cables #10486

Closed
dreng opened this issue Sep 27, 2022 · 10 comments · Fixed by #11414
Closed

Add buttons to edit cables #10486

dreng opened this issue Sep 27, 2022 · 10 comments · Fixed by #11414
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@dreng
Copy link
Contributor

dreng commented Sep 27, 2022

NetBox version

v3.3.4

Feature type

Change to existing functionality

Proposed functionality

The device view provides tabs for interfaces, power ports etc. On every line we have a button to connect a cable or, if a cable is connected already, a button to disconnect the cable.

I've got a PR ready that adds a button to all kinds of connection overviews (console ports, power ports, front ports, interfaces etc.). It looks like this:

grafik

Use case

What I miss here is a button to go directly to the edit page of the cable including a redirect to the page we came from. Best thing you can do at the moment is to click the link in the "Cable" column (if not hidden), edit the cable and go back to the connections overview manually. This approach is kinda cumbersome.

Database changes

None

External dependencies

None

@dreng dreng added the type: feature Introduction of new functionality to the application label Sep 27, 2022
@jeremystretch
Copy link
Member

There are quite a few buttons there as it is. What about merging several of the cable-relevant buttons under a dropdown (similar to the add/edit/changelog actions)? IMO it would make sense to list the trace cable, edit cable (new), and delete cable actions under a single button. There's also the toggle button to change the cable status, but that one probably needs to stay separate as it's a Javascript function.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Oct 3, 2022
@dreng
Copy link
Contributor Author

dreng commented Oct 3, 2022

I absolutely agree. At first I wanted to do it that way too, but I struggled a bit with choosing a suitable symbol. The symbol to change things would be the pencil, but there's another button with a pencil in this context already. A yellow dropdown menu with a cable icon could be a solution.

Another problem is that the "new" button is already a dropdown menu. It would certainly be irritating if there were an entry for "trace cable" underneath this button next to "interface", "font port", etc. Perhaps it would help to rename the entries. "interface" would then become "connect to interface". Is that roughly what you propose? Or should we just leave the trace button alone and consolidate only edit and delete?

@dreng
Copy link
Contributor Author

dreng commented Oct 3, 2022

Just to make the options clear that has been proposed:

First variant is to consolidate all of the buttons. This means that there is no trace button anymore at all if no cable is connected.
image image

Second variant is to leave trace button where it is.
image image

@sieuwe
Copy link

sieuwe commented Oct 6, 2022

I would keep the trace as a separate button, we use that frequently on cables that are not attached to an interface on both sides.

@bluikko
Copy link
Contributor

bluikko commented Oct 24, 2022

A bit off-topic but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"?

@dreng
Copy link
Contributor Author

dreng commented Oct 24, 2022

A bit off-topic ...

Well, yes. I would appreciate, if we could get the proposed topic done and discuss your proposal in a separate FR.

...but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"?

This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature.

@bluikko
Copy link
Contributor

bluikko commented Oct 24, 2022

This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature.

The reason I raised is that it was mentioned there is clutter and many buttons already. So maybe there could've been a way to reduce that clutter. But as you say, it is not possible.
I do not think further discussion on the "Mark planned" button is then necessary and I don't see how the amount of buttons could be reduced. Trace should definitely stay as a button since it is one of the most used buttons IMO.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Dec 24, 2022
@dreng
Copy link
Contributor Author

dreng commented Dec 26, 2022

@jeremystretch
Unfortunately, after my last reply, there was no more recourse.
I would like to kindly ask what is necessary to accept this feature request. Actually, all we need here is a decision on whether and which of the two proposed scenarios should be implemented. I can still offer to do the work.

@jeremystretch
Copy link
Member

Second variant is to leave trace button where it is.

Seems like this is the preferable approach. @dreng I'll assign this to you.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Jan 5, 2023
jeremystretch pushed a commit that referenced this issue Jan 6, 2023
* Added buttons to edit cables

* Revert change that did not address this branch

* Consolidated buttons

* moved back trace button / added permission checks

* reverted disabled trace button
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants