Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing the Enter key in the Quick Search textbox activates the Bulk Edit button #11178

Closed
atownson opened this issue Dec 14, 2022 · 1 comment · Fixed by #11183
Closed

Pressing the Enter key in the Quick Search textbox activates the Bulk Edit button #11178

atownson opened this issue Dec 14, 2022 · 1 comment · Fixed by #11183
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@atownson
Copy link
Contributor

NetBox version

v3.3.9

Python version

3.8

Steps to Reproduce

  1. Navigate to any model's list view (i.e. .../dcim/devices/).
  2. Ensure there is at least one instantiated model present.
  3. Type something in the Quick Search textbox and hit the Enter key when done.

Expected Behavior

The search is performed once the Enter key is pressed.

Observed Behavior

The Enter key activates the Bulk Edit button, and an exception that no items were selected is shown.

image

The workaround for this is to obviously not hit the Enter key, but rather wait on the search to be applied. I believe this behavior was introduced in v3.3.8.
@atownson atownson added the type: bug A confirmed report of unexpected behavior in the application label Dec 14, 2022
@kkthxbye-code kkthxbye-code added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Dec 14, 2022
@kkthxbye-code
Copy link
Contributor

Regression from #10848

The quick search input element is now inside the form. @arthanson

@arthanson arthanson self-assigned this Dec 14, 2022
@arthanson arthanson mentioned this issue Dec 14, 2022
Merged
@kkthxbye-code kkthxbye-code added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 14, 2022
jeremystretch added a commit that referenced this issue Dec 15, 2022
@jeremystretch
Changelog for #11175, #11178
e4f5407
@jeremystretch jeremystretch mentioned this issue Dec 16, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

11178 fix quick search press enter button netbox-community/netbox
3 participants
@arthanson @kkthxbye-code @atownson