Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Roles: Add Virtual Maschines view #11228

Closed
ShellBoyAFK opened this issue Dec 18, 2022 · 7 comments · Fixed by #11500
Closed

Device Roles: Add Virtual Maschines view #11228

ShellBoyAFK opened this issue Dec 18, 2022 · 7 comments · Fixed by #11500
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ShellBoyAFK
Copy link

NetBox version

v3.3.9

Feature type

Change to existing functionality

Proposed functionality

Under Device Roles, only the Devices are displayed in the detailed view of the individual roles.

But not the virtual machines associated with them.

This does not look complete. Maybe this was forgotten.

vms

Use case

I think the use case is obvious or?

So that you can see immediately in the respective role which VMs have this role

Database changes

?

External dependencies

?
@ShellBoyAFK ShellBoyAFK added the type: feature Introduction of new functionality to the application label Dec 18, 2022
@ShellBoyAFK ShellBoyAFK changed the title Device Roles View add Virtual Maschines Device Roles: Add Virtual Maschines view Dec 18, 2022
@jeremystretch
Copy link
Member

IMO it doesn't make sense to display two potentially large tables one on top of the other. Viewing the VMs table would require the user to scroll through the entire devices table, assuming they even know it's there. Maybe child tabs (like for components under the device view) would be more suitable?

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Dec 22, 2022
@hagbarddenstore
Copy link
Contributor

hagbarddenstore commented Dec 22, 2022 via email •
edited by jeremystretch
Loading

@jeremystretch

This comment was marked as off-topic.

Sign in to view
@ShellBoyAFK
Copy link
Author

sound good thx

@hagbarddenstore

This comment was marked as off-topic.

Sign in to view
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jan 5, 2023
@abhi1693
Copy link
Member

@jeremystretch I'd like to take this

@kkthxbye-code kkthxbye-code added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 13, 2023
@kkthxbye-code
Copy link
Contributor

@abhi1693 - All yours.

@abhi1693 abhi1693 mentioned this issue Jan 13, 2023
Merged
@jeremystretch jeremystretch mentioned this issue Jan 16, 2023
Closed
jeremystretch added a commit that referenced this issue Jan 20, 2023
@jeremystretch
Changelog for #11118, #11227, #11228
188f773
@jeremystretch jeremystretch mentioned this issue Jan 20, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added device and vm tab on device role
5 participants
@kkthxbye-code @hagbarddenstore @abhi1693 @jeremystretch @ShellBoyAFK