Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show containing Prefixes and Aggregates when doing a site-wide partial search #11685

Closed
kkthxbye-code opened this issue Feb 7, 2023 · 1 comment · Fixed by #11686
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@kkthxbye-code
Copy link
Contributor

NetBox version

v3.4.4

Feature type

Change to existing functionality

Proposed functionality

Relevant bug report: #11315
Relevant discussion: #11665

In short the goal is to find prefixes and aggregates based on the input, if the input is parsable as an netaddr.IPNetwork.

Use case

It is useful to get the parent prefix if searching for both existing and non-existent IPAddresses and more closely matches the previous global search. More reasoning can be found in the linked bug report.

Database changes

While no actual database changes should be necessary, changing the CachedValue.value field to a custom field type inherating TextField generates a migration, but there should be no actual SQL schema changes. See the PR.

External dependencies

None

@PieterL75
Copy link
Contributor

I'm really waiting for this one before I push 3.4 to production. The search results are indeed lacking this information and is a requirement for my users.
Too bad I did not catch that in the beta tests I did. Just overwhelmed by the speed and nice results :-)

@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Feb 17, 2023
jeremystretch added a commit that referenced this issue Feb 20, 2023
jeremystretch added a commit that referenced this issue Feb 20, 2023
jeremystretch added a commit that referenced this issue Feb 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
3 participants