Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JobResult to Job and move to the "core" app #12067

Closed
jeremystretch opened this issue Mar 27, 2023 · 0 comments
Closed

Rename JobResult to Job and move to the "core" app #12067

jeremystretch opened this issue Mar 27, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.5

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Mar 27, 2023 •
edited
Loading

Proposed Changes

This proposal entails two changes:

  1. Name the JobResult class to Job
  2. Move the class from extras to the new core app

The REST API endpoint for jobs would thus move from /api/extras/job-results to /api/core/jobs/. Similarly, the JOBRESULT_RETENTION configuration parameter will be renamed to JOB_RETENTION.

Justification

The core app being introduced in v3.5 serves to hold models which are not directly useful but empower other functionality in NetBox. Jobs meet this criteria, similar to other models which are being introduced in core: DataSource, DataFile, and ManagedFile.

Renaming the class also feels appropriate as the model is used to track the entire lifecycle of a job, not just its result.
@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: under review Further discussion is needed to determine this issue's scope and/or implementation status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 27, 2023
@jeremystretch jeremystretch self-assigned this Mar 27, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Mar 27, 2023
@jeremystretch jeremystretch mentioned this issue Mar 27, 2023
Merged
jeremystretch added a commit that referenced this issue Mar 27, 2023
@jeremystretch
#12067: Fix ordering for JobResult replication
61e2073
@jeremystretch jeremystretch mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.5
Development

No branches or pull requests
1 participant
@jeremystretch