Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the napalm_driver and napalm_args fields from Platform #12320

Closed
jeremystretch opened this issue Apr 21, 2023 · 1 comment
Closed

Remove the napalm_driver and napalm_args fields from Platform #12320

jeremystretch opened this issue Apr 21, 2023 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v3.6

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the napalm_driver and napalm_args fields from the Platform model.

Justification

NAPALM integration was moved to a plugin in NetBox v3.5 under #10520. These fields were retained to ease migration to the plugin, but are no longer needed once the plugin has been installed.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Apr 21, 2023
@jeremystretch jeremystretch added this to the v3.6 milestone Apr 21, 2023
@jeremystretch jeremystretch added type: deprecation Removal of existing functionality or behavior and removed type: housekeeping Changes to the application which do not directly impact the end user labels Apr 21, 2023
@jeremystretch jeremystretch self-assigned this May 16, 2023
jeremystretch added a commit that referenced this issue May 16, 2023
@jeremystretch
Closes #12320: Remove obsolete fields napalm_driver and napalm_args f…
4208b79 
…rom Platform
@PieterL75
Copy link
Contributor

@jeremystretch Can we keep the 'driver' field ?
My automation uses napalm, and gets the driver from the Platform assigned to the Device.
Maybe just rename it to 'DeviceDriver' in stead of NapalmDriver ?
Other option is to use CustomFields, but it feels like a proper field to retain on the Platform model

@jeremystretch jeremystretch mentioned this issue Aug 30, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v3.6
Development

No branches or pull requests
2 participants
@jeremystretch @PieterL75