Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script and reports serializer to return NetBox standardized results #13037

Closed
abhi1693 opened this issue Jun 28, 2023 · 0 comments
Closed

Update script and reports serializer to return NetBox standardized results #13037

abhi1693 opened this issue Jun 28, 2023 · 0 comments
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@abhi1693
Copy link
Member

NetBox version

v3.5.4

Feature type

Change to existing functionality

Proposed functionality

The serialized data should be moved under results key and add count key if possible.

https://github.com/netbox-community/netbox/blob/develop/netbox/extras/api/views.py#L210

https://github.com/netbox-community/netbox/blob/develop/netbox/extras/api/views.py#L310

This will allow the results to be displayed in slim-select

Use case

I want to use scripts GET API in the plugin model to display list of choices to the user. This does not work as the result returned does not have the results key.

Database changes

No response

External dependencies

No response
@abhi1693 abhi1693 added the type: feature Introduction of new functionality to the application label Jun 28, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 4, 2023
abhi1693 added a commit that referenced this issue Aug 4, 2023
@abhi1693
adds standardized list API for scripts and reports #13037
b35ffff
abhi1693 added a commit that referenced this issue Aug 4, 2023
@abhi1693
adds standardized list API for scripts and reports #13037
6776232
abhi1693 added a commit that referenced this issue Aug 4, 2023
@abhi1693
adds standardized list API for scripts and reports #13037
98006a0
@abhi1693 abhi1693 mentioned this issue Aug 4, 2023
Merged
abhi1693 added a commit that referenced this issue Aug 4, 2023
@abhi1693
adds module name to the display #13037
9f19b99
jeremystretch pushed a commit that referenced this issue Aug 4, 2023
@abhi1693
Adds standardized list API for scripts and reports (#13382)
5361594 
* adds standardized list API for scripts and reports #13037

* adds standardized list API for scripts and reports #13037

* adds standardized list API for scripts and reports #13037

* adds module name to the display #13037
jeremystretch added a commit that referenced this issue Aug 9, 2023
@jeremystretch
Changelog for #12814, #13037, #13376, #13410
ff59845
@jeremystretch jeremystretch mentioned this issue Aug 30, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhi1693 @jeremystretch