Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace format() with f-strings #13298

Closed
DanSheps opened this issue Jul 28, 2023 · 2 comments
Closed

Replace format() with f-strings #13298

DanSheps opened this issue Jul 28, 2023 · 2 comments
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@DanSheps
Copy link
Member

Proposed Changes

Replacing any instance of format() with f-strings.

Justification

As per @jsenecal in #13296 f-strings offer some minor optimizations for performance and code readability.

We should replace format() where possible
@DanSheps DanSheps added type: housekeeping Changes to the application which do not directly impact the end user status: accepted This issue has been accepted for implementation labels Jul 28, 2023
@DanSheps DanSheps assigned DanSheps and unassigned DanSheps Jul 28, 2023
@jeremystretch
Copy link
Member

As I explained on Friday, the use of format() in many places is required to support translation, which is currently an ongoing initiative for v4.0. Please do not start making blanket changes to format strings until that work has been completed.

In the meantime, I'll point out that there are currently 41 open bug reports looking for owners.

@jeremystretch
Copy link
Member

We can continue to replace calls to format() opportunistically where appropriate, but I don't think we'll ever be in a place to justify the effort of a concerted audit for this.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@jeremystretch jeremystretch removed the status: accepted This issue has been accepted for implementation label May 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanSheps @jeremystretch