Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11478 - Add vc_interfaces flag to control selection of VC interfaces #13296

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Fix #11478 - Add vc_interfaces flag to control selection of VC interfaces #13296

merged 11 commits into from
Aug 30, 2023

Conversation

DanSheps
Copy link
Member

Fixes: #11478 - Add vc_interfaces flag to control selection of VC interfaces

  • Create a vc_interfaces flag that can be used for controlling device queryset generation.
  • Update interface edit form to account for new flag

jsenecal
jsenecal reviewed Jul 28, 2023
View reviewed changes
netbox/dcim/filtersets.py Outdated Show resolved Hide resolved
This was referenced Jul 28, 2023
Closed
Closed
jeremystretch
jeremystretch requested changes Aug 11, 2023
View reviewed changes
netbox/dcim/filtersets.py Outdated Show resolved Hide resolved
@DanSheps DanSheps changed the base branch from develop to feature August 11, 2023 16:59
@DanSheps DanSheps removed the request for review from jsenecal August 21, 2023 18:37
jeremystretch
jeremystretch requested changes Aug 21, 2023
View reviewed changes
netbox/dcim/tests/test_filtersets.py Outdated Show resolved Hide resolved
netbox/dcim/filtersets.py Outdated Show resolved Hide resolved
jeremystretch
jeremystretch requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a note to the v3.6 release notes indicating the breaking change to the device & device_id filters for interfaces?

netbox/dcim/tests/test_filtersets.py Outdated Show resolved Hide resolved
netbox/dcim/tests/test_filtersets.py Outdated Show resolved Hide resolved
netbox/dcim/tests/test_filtersets.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch mentioned this pull request Aug 23, 2023
Closed
@DanSheps
Copy link
Member Author

I think I covered everything @jeremystretch

@jeremystretch jeremystretch mentioned this pull request Aug 30, 2023
Closed
@jeremystretch jeremystretch merged commit 1854a6b into feature Aug 30, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 11478-fix-cabling-interface-display branch August 30, 2023 13:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsenecal jsenecal jsenecal approved these changes

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patching front port to virtual chassis member interface is broken in UI
3 participants
@DanSheps @jsenecal @jeremystretch