Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CI workflow to check for missing database migrations #14872

Closed
jeremystretch opened this issue Jan 19, 2024 · 0 comments
Closed

Extend CI workflow to check for missing database migrations #14872

jeremystretch opened this issue Jan 19, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Extend our CI workflow to check for missing Django migrations with manage.py makemigrations --check.

Justification

Our pre-commit hook checks for these but CI does not.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 19, 2024
@jeremystretch jeremystretch self-assigned this Jan 19, 2024
jeremystretch added a commit that referenced this issue Jan 19, 2024
@jeremystretch
#14872: Permit makemigrations --check without setting DEVELOPER=True
1651a30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch