Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals not working if HTMX Navigation is enabled #15580

Closed
arthanson opened this issue Mar 29, 2024 · 3 comments
Closed

Modals not working if HTMX Navigation is enabled #15580

arthanson opened this issue Mar 29, 2024 · 3 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@arthanson
Copy link
Collaborator

arthanson commented Mar 29, 2024 •
edited by jeremystretch
Loading

Deployment Type

Self-hosted

NetBox Version

v4.0.0-dev

Python Version

3.8

Steps to Reproduce

  1. Go to user preferences and set "HTMX Navigation" to Enabled
  2. Go to Devices and click the "Configure Table" button

Expected Behavior

The configure table modal should pop up

Observed Behavior

No modal appears.
@arthanson arthanson added type: bug A confirmed report of unexpected behavior in the application status: needs triage This issue is awaiting triage by a maintainer labels Mar 29, 2024
@arthanson arthanson changed the title "Configure Table" not working if HTMX Navigation is enabled Modals not working if HTMX Navigation is enabled Mar 29, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Mar 29, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Mar 29, 2024
@jeremystretch
Copy link
Member

AFAICT this occurs only after certain actions, such as visiting the home page or updating preferences. Navigating directly to an object list view and then navigating normally via the menu with HTMX enabled works fine; the table config dialogs open as expected.

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Apr 3, 2024
@jeremystretch jeremystretch removed this from the v4.0 milestone Apr 3, 2024
jeremystretch added a commit that referenced this issue Apr 22, 2024
@jeremystretch
Fixes #15580: Fix rendering of modals with HTMX enabled
fdf097d
@jeremystretch jeremystretch mentioned this issue Apr 22, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 22, 2024
@jeremystretch
Fixes #15580: Fix rendering of modals with HTMX enabled
c43b929
@opericgithub
Copy link

opericgithub commented Apr 22, 2024 •
edited
Loading

Config table window opens now, but I'm unable to move columns from one list to another (add and remove buttons don't function).

Also, when I click save, UI becomes unresponsive

@jeremystretch
Copy link
Member

@opericgithub please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arthanson @DanSheps @jeremystretch @opericgithub