Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the tab template context variable in plugins documentation #15727

Closed
markkuleinio opened this issue Apr 16, 2024 · 1 comment · Fixed by #15728
Closed

Add the tab template context variable in plugins documentation #15727

markkuleinio opened this issue Apr 16, 2024 · 1 comment · Fixed by #15728
Assignees
@markkuleinio
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@markkuleinio
Copy link
Contributor

Change Type

Addition

Area

Plugins

Proposed Changes

Currently https://docs.netbox.dev/en/stable/plugins/development/views/#additional-tabs is missing the detail that "tab": self.tab template context variable is needed for the additional tab to work correctly.
@markkuleinio markkuleinio added status: needs triage This issue is awaiting triage by a maintainer type: documentation A change or addition to the documentation labels Apr 16, 2024
markkuleinio added a commit to markkuleinio/netbox that referenced this issue Apr 16, 2024
@markkuleinio
Closes netbox-community#15727: Add tab template context variable in t…
b8db022 
…he plugin doc
@markkuleinio markkuleinio mentioned this issue Apr 16, 2024
Merged
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 16, 2024
@arthanson arthanson removed their assignment Apr 16, 2024
@markkuleinio
Copy link
Contributor Author

"Needs owner" --> was it so that one needs to comment the issue before able to proceed with documentation PR

@DanSheps DanSheps added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 16, 2024
jeremystretch pushed a commit that referenced this issue Apr 17, 2024
@markkuleinio @jeremystretch
Closes #15727: Add tab template context variable in the plugin doc
4284028
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@markkuleinio @JCWasmx86
Closes netbox-community#15727: Add tab template context variable in t…
4420db9 
…he plugin doc
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markkuleinio markkuleinio

Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #15727: Add tab template context variable in the plugin doc markkuleinio/netbox
3 participants
@arthanson @DanSheps @markkuleinio