Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other VC device interfaces not showing up when bulk-editing/Edit selected #15877

Closed
Azmodeszer opened this issue Apr 28, 2024 · 2 comments · Fixed by #15941
Closed

Other VC device interfaces not showing up when bulk-editing/Edit selected #15877

Azmodeszer opened this issue Apr 28, 2024 · 2 comments · Fixed by #15941
Assignees
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@Azmodeszer
Copy link
Contributor

Azmodeszer commented Apr 28, 2024

Deployment Type

Self-hosted

NetBox Version

v3.7.6

Python Version

3.10

Steps to Reproduce

  1. Create a Virtual Chassis, add two or more devices, each with at least one physical interface.
  2. Create LAG1 on device1, LAG2 on device2.
  3. Bulk edit existing interfaces on device2 (although simply using "Edit selected" on a single interface is enough) and try to select LAG1 as LAG interface.
  4. Try the same with device1/LAG2.

Expected Behavior

No matter which particular device the interface belongs to, all LAGs show up in the dropdown menu since they're part of the same VC. And indeed that's how it works when directly editing an interface.

Observed Behavior

Only LAG1/2 shows up when editing (an) interface(s) native to device1/2. (seems to apply to all kinds of Related Interfaces, not just LAGs)

@Azmodeszer Azmodeszer added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 28, 2024
@jeffgdotorg
Copy link
Contributor

Thanks for the bug report. I was able to reproduce it in the lab.

@jeffgdotorg jeffgdotorg added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 29, 2024
@jeffgdotorg jeffgdotorg removed their assignment Apr 29, 2024
@jeremystretch
Copy link
Member

When editing a single interface, the list of candidate LAG interfaces is fetched by filtering with virtual_chassis_member_id, which matches all interfaces assigned to the VC. When bulk editing, the device_id filter is used instead; this matches only interfaces belonging to the local device. We can tweak the bulk edit form to filter by the former filter if the device is a VC member.

@jeremystretch jeremystretch self-assigned this May 3, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 3, 2024
jeremystretch added a commit that referenced this issue May 3, 2024
jeremystretch added a commit that referenced this issue May 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
3 participants