Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French login prompt overflows on lines #15999

Closed
altf4arnold opened this issue May 7, 2024 · 4 comments · Fixed by #16006
Closed

French login prompt overflows on lines #15999

altf4arnold opened this issue May 7, 2024 · 4 comments · Fixed by #16006
Assignees
@altf4arnold
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@altf4arnold
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

v4.0.0

Python Version

3.11

Steps to Reproduce

go to login prompt when your browser is in french.

Expected Behavior

the name "nom d'utilisateur" sould not end up with single words on same line

Observed Behavior

Screenshot 2024-05-07 at 14 53 12
@altf4arnold altf4arnold added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 7, 2024
@jeremystretch
Copy link
Member

We can address this by moving the field labels above the fields as per the Tabler example:

screenshot

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 7, 2024
@altf4arnold
Copy link
Contributor Author

I can take a look to fix that. Do you want me to work on a PR for it?

@jeremystretch
Copy link
Member

@altf4arnold sure, go for it!

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 7, 2024
This was referenced May 7, 2024
Closed
Merged
@altf4arnold
Copy link
Contributor Author

There we go

@jeremystretch jeremystretch added the topic: UI/UX User interface or user experience related work label May 8, 2024
jeremystretch added a commit that referenced this issue May 8, 2024
@jeremystretch
#15999: Additional cleanup
6e658d4
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@altf4arnold altf4arnold

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#15999 Login form
[FIX] putting the labels of the forms above the fields
3 participants
@arthanson @jeremystretch @altf4arnold