Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable uWSGI logging by default #16034

Closed
markkuleinio opened this issue May 8, 2024 · 3 comments · Fixed by #16040
Closed

Disable uWSGI logging by default #16034

markkuleinio opened this issue May 8, 2024 · 3 comments · Fixed by #16040
Assignees
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@markkuleinio
Copy link
Contributor

NetBox version

v4.0.0

Feature type

Change to existing functionality

Proposed functionality

Currently the NetBox-default uWSGI configuration causes all requests to be logged in uWSGI level, in addition to the normal reverse proxy level, thus consuming the journal log in systemd configuration.

I propose defaulting to uWSGI request logging disabled, while still logging application errors.

Use case

Current uWSGI request logging consumes the systemd journal log capacity, possibly causing other application logs to purge when journal log limits are exceeded.

Since the default NetBox installation already logs the requests in the reverse proxy logs, uWSGI-level logging can be limited to error logging only.

If someone needs the uWSGI logging as well, they can easily change the configuration setting present in the default NetBox uwsgi.ini.

Database changes

None

External dependencies

None

@markkuleinio markkuleinio added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 8, 2024
@markkuleinio
Copy link
Contributor Author

If this is accepted, I can submit the PR.

@jeremystretch jeremystretch added type: documentation A change or addition to the documentation status: accepted This issue has been accepted for implementation and removed type: feature Introduction of new functionality to the application status: needs triage This issue is awaiting triage by a maintainer labels May 8, 2024
@jeremystretch
Copy link
Member

@markkuleinio sounds reasonable. I've assigned this to you. (Also reclassified this as a documentation change as the reference uWSGI config isn't part of the NetBox code base.)

@markkuleinio
Copy link
Contributor Author

Thanks. I was going to add the config lines to the end of uwsgi.ini, but I already have #16035 touching the same position, so I'll hold this for now.

markkuleinio added a commit to markkuleinio/netbox that referenced this issue May 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants