Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround to make reloads work with pyuwsgi #16056

Closed
markkuleinio opened this issue May 9, 2024 · 2 comments · Fixed by #16062
Closed

Add workaround to make reloads work with pyuwsgi #16056

markkuleinio opened this issue May 9, 2024 · 2 comments · Fixed by #16062
Assignees
@markkuleinio
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@markkuleinio
Copy link
Contributor

Change Type

Addition

Area

Installation/upgrade

Proposed Changes

As discussed in #16043, when using pyuwsgi package (as used in the current NetBox instructions) there is a problem where uWSGI detects the Python binary incorrectly, and consequently uWSGI reloads won't work.

Other references:

I'm proposing adding the identified workaround in the NetBox-provided uwsgi.ini:

; workaround to make uWSGI reloads work with pyuwsgi (not to be used if using uwsgi package instead)
binary-path = venv/bin/python
@markkuleinio markkuleinio added status: needs triage This issue is awaiting triage by a maintainer type: documentation A change or addition to the documentation labels May 9, 2024
@markkuleinio
Copy link
Contributor Author

If this is accepted, I can send the PR.

@jeffgdotorg jeffgdotorg removed their assignment May 9, 2024
@jeffgdotorg jeffgdotorg added status: accepted This issue has been accepted for implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 9, 2024
@jeffgdotorg
Copy link
Contributor

LGTM. Thanks @markkuleinio.

markkuleinio added a commit to markkuleinio/netbox that referenced this issue May 9, 2024
@markkuleinio
Closes netbox-community#16056: Add binary-path configuration in uwsgi…
896afca 
….ini
@markkuleinio markkuleinio mentioned this issue May 9, 2024
Merged
jeremystretch pushed a commit that referenced this issue May 9, 2024
@markkuleinio @jeremystretch
Closes #16056: Add binary-path configuration in uwsgi.ini
2a06e19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markkuleinio markkuleinio

Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16056: Add binary-path configuration in uwsgi.ini markkuleinio/netbox
2 participants
@jeffgdotorg @markkuleinio